Code review
As a PR author
- Keep PRs small: one concern, one PR
- Write a clear title using semantic commit format
- Add a one-paragraph description of what changed and why
- Self-review your diff before requesting review
- Respond to every comment, even if just "done"
As a reviewer
- Review within one business day
- Focus on correctness, security, and clarity - in that order
- Be specific: point to the line, explain the issue, suggest a fix
- Approve when it's ready, don't nitpick style if it passes linting
- Check for: hardcoded secrets, missing error handling, untested edge cases
Merging
- Only the reviewer merges, never the author
- Use squash-and-merge into
main - Delete the branch after merge